Repository navigation
fix(pr-review-cli): name the distinct bytes on a split review notice too - #987
Conversation
…e too The chunks notice printed distinct-bytes= only on the one-review branch (the diff fits once its copies are left out), so a split review's notice carried none and a check that reads the field saw nothing for six hours of split reviews. distinct_bytes now defaults to the scope's bytes before the copy check, and the split notice prints it, in all three job copies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security findings in the incremental change since 7333e16, which covers
critical-findings: 0 |
|
claude-review reviewed No findings. I reviewed only the change since 7333e16 (
|
The copy check measured the distinct diff into distinct_bytes before the count test, so a copy list that did not match the scope left the split notice with the smaller measured size beside excluded=0. The measured size now has its own variable, and distinct_bytes takes it only where excluded=$COPIES does, in all three job copies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: hub L261 add-on. PR Lane's completion check for #984 reads
distinct-bytes=from the review split notice and saw none in six hours of reviews (03:5x-09:0xZ on 2026-11-04).Summary
The
pr-review-cli chunksnotice printeddistinct-bytes=only on #984's one-review branch, where the diff fits once its copies are left out. A split review, such as melodic-software/claude-code-plugins#13097's 40+40+3 run (41780888786), printedchunks= bytes= files= excluded=and no distinct bytes. So the field was missing whenever that branch did not fire.Fix
.github/workflows/pr-review-cli.yml, all three job copies:distinct_bytesdefaults to$SCOPE_BYTESbefore the copy check. With no copies left out, the distinct diff is the whole scope.distinct-bytes=$distinct_bytesbetweenbytes=andfiles=.Verification
pr-review-cli.test.cjs: 76/76. The split test asserts the notice linechunks=2 bytes=700000 distinct-bytes=700000 files=2,1 excluded=0, and it fails on main's workflow.Related
🤖 Generated with Claude Code