Repository navigation
ci: dogfood pr-automerge-dependabot in pr-require-checks - #683
Merged
Merged
Conversation
Arm auto-merge on this repository's own vendor Dependabot bumps through a thin caller job, as every other repository does through its caller file. The job runs on pull_request events only, grants write permissions at job level, and stays out of ci-status, which the arm waits on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pin the reusable to a merged SHA, as the Claude lanes are, so a Dependabot pull request that bumps an action inside the reusable cannot run that code with the write token before it merges. Add the job to the test that keeps advisory jobs out of ci-status, so a dependency on it fails the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton
marked this pull request as ready for review
October 5, 2026 00:36
kyle-sexton
enabled auto-merge (squash)
October 5, 2026 00:36
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No related issue: found by the actions-conventions Phase 8 sanity check (16 of 17 repos passed; ci-workflows lacked an auto-merge caller).
Summary
ci-workflows is the only repository without a caller of the shared
pr-automerge-dependabotreusable, so its own vendor Dependabot bumps (e.g. #674) never arm auto-merge, contrary to the org Dependabot lanes policy (standards#684). A separate caller file cannot exist here becausepr-automerge-dependabot.ymlis the reusable itself, so this adds a thin dogfood caller job topr-require-checks.yml, the pattern the Claude lanes already use.Fix
pr-automerge-dependabotin.github/workflows/pr-require-checks.yml:pull_requestevents only, the same action predicate aspr-review. It has job-scopedcontents: writeandpull-requests: write; workflow-level permissions are unchanged.@fb56986… # v0.36.0), not./, so a pull request, a Dependabot bump of an action inside the reusable included, cannot redefine the code that holds the write token.ci-statusdoes not depend on the job, because arming waits onci-status.ci-fanout-consolidation.test.cjsnow lists it among the jobs that stay out ofci-status.Verification
actionlint .github/workflows/pr-require-checks.yml: exit 0.node --test .github/scripts/*.test.cjs: all pass.pr-require-checks.yml); a local review stands in for them.pr-automerge-dependabot / …check and auto-merge armed.Related
🤖 Generated with Claude Code