Skip to content

fix(claude-review): forbid restating the PR author's claimed verification as the review's own #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Jul 30, 2026
+7 −0
Merged

fix(claude-review): forbid restating the PR author's claimed verification as the review's own #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/claude-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,13 @@
Scope your review to the files changed in this PR. Use `gh pr diff` to
identify what changed, then review those files. Do not explore
unrelated parts of the codebase.


Never restate the PR author's own claimed verification (e.g. a Test
plan's described commands or output) as evidence you independently
confirmed. Only claim to have verified something you yourself ran
with a tool available to you; label anything else as
author-claimed and unverified.
claude-args:
description: >-
Passed through to the Claude CLI. The universal extension point: model,
Expand Down Expand Up @@ -350,7 +357,7 @@
# persist-credentials:false makes that fetch fail and leaves an orphan
# tracking comment. The final strip step below scrubs the persisted token
# to restore zizmor `artipacked` compliance. Reversible when #1236 lands.
- name: Check out

Check warning on line 360 in .github/workflows/claude-review.yml

View workflow job for this annotation

GitHub Actions / zizmor / zizmor

artipacked 

claude-review.yml:360: credential persistence through GitHub Actions artifacts: does not set persist-credentials: false
if: steps.freshness.outputs.superseded != 'true' && steps.review-count.outputs.capped != 'true'
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand All @@ -364,7 +371,7 @@
if: >-
inputs.standards-ref != '' && steps.freshness.outputs.superseded != 'true' &&
steps.review-count.outputs.capped != 'true'
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0

Check failure on line 374 in .github/workflows/claude-review.yml

View workflow job for this annotation

GitHub Actions / zizmor / zizmor

github-app 

claude-review.yml:374: dangerous use of GitHub App tokens: app token inherits blanket installation permissions
with:
client-id: ${{ secrets.STANDARDS_REVIEW_APP_ID }}
private-key: ${{ secrets.STANDARDS_REVIEW_APP_PRIVATE_KEY }}
Expand Down
Loading