Skip to content

semantic-pr prerequisite-result description contradicts the enforced always() caller shape #140

Description

@kyle-sexton

What

semantic-pr.yml's prerequisite-result input description (since #106, present in v0.6.0 @ ec91c34) tells callers to use if: !cancelled(). The runner-policy validator's failClosedSelectorConditionStatus requires exactly if: ${{ always() }} for selector-result reporters, and every Wave 3 caller ships always().

#134 (option (a) of #131) reconciled do-not-merge-gate.yml and the README to the enforced always() shape but did not sweep semantic-pr.yml, so the same rejected-shape recommendation still ships there.

Fix

Docs-only: mirror #134's wording in semantic-pr.yml's prerequisite-result description (and its job comment, which references the caller's if: !cancelled()).

Surfaced by a codex review finding on melodic-software/standards#175 (v0.6.0 contract registration); it does not block that registration — the contract encodes the enforced shape, and pin bumps leave caller conditions untouched.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions