Filter function: brightness()#25057
Merged
Conversation
Contributor
|
Preview URLs Flaws (1)URL:
(comment last updated: 2023-03-20 15:44:06) |
Contributor
|
Sorry for the delay on this one, Estelle. Taking a look now. |
dipikabh
requested changes
Mar 15, 2023
estelle
commented
Mar 15, 2023
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
dipikabh
requested changes
Mar 20, 2023
dipikabh
requested changes
Mar 20, 2023
Contributor
There was a problem hiding this comment.
Just two remaining items - unhiding the html code and moving the example up, that is, the example "using the filter property" before the example "using the backdrop-filter property".
Plus code fencing is missing in two places
dipikabh
approved these changes
Mar 21, 2023
Contributor
dipikabh
left a comment
There was a problem hiding this comment.
Thanks for the improvements to this page 👍
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the 3rd in the series. Revamped based on SC call feedback.