Skip to content

Filter function: brightness()#25057

Merged
dipikabh merged 19 commits intomdn:mainfrom
estelle:brightness
Mar 21, 2023
Merged

Filter function: brightness()#25057
dipikabh merged 19 commits intomdn:mainfrom
estelle:brightness

Conversation

@estelle
Copy link
Copy Markdown
Member

@estelle estelle commented Mar 3, 2023

This is the 3rd in the series. Revamped based on SC call feedback.

@estelle estelle requested a review from a team as a code owner March 3, 2023 22:14
@estelle estelle requested review from dipikabh and removed request for a team March 3, 2023 22:14
@github-actions github-actions Bot added the Content:CSS Cascading Style Sheets docs label Mar 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2023

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/filter-function/brightness
Title: brightness()
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/filter_effects

(comment last updated: 2023-03-20 15:44:06)

@dipikabh
Copy link
Copy Markdown
Contributor

Sorry for the delay on this one, Estelle. Taking a look now.

Copy link
Copy Markdown
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologize for the delay, @estelle. I've added my feedback.

Comment thread files/en-us/web/css/filter-function/brightness/index.md Outdated
Comment thread files/en-us/web/css/filter-function/brightness/index.md Outdated
Comment thread files/en-us/web/css/filter-function/brightness/index.md Outdated
Comment thread files/en-us/web/css/filter-function/brightness/index.md
Comment thread files/en-us/web/css/filter-function/brightness/index.md Outdated
Comment thread files/en-us/web/css/filter-function/brightness/index.md Outdated
Comment thread files/en-us/web/css/filter-function/brightness/index.md Outdated
Comment thread files/en-us/web/css/filter-function/brightness/index.md Outdated
Comment thread files/en-us/web/css/filter-function/brightness/index.md Outdated
Comment thread files/en-us/web/css/filter-function/brightness/index.md
Comment thread files/en-us/web/css/filter-function/brightness/index.md Outdated
estelle and others added 7 commits March 15, 2023 16:55
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle estelle requested a review from dipikabh March 16, 2023 16:53
Comment thread files/en-us/web/css/filter-function/brightness/index.md Outdated
Copy link
Copy Markdown
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two remaining items - unhiding the html code and moving the example up, that is, the example "using the filter property" before the example "using the backdrop-filter property".

Plus code fencing is missing in two places

Comment thread files/en-us/web/css/filter-function/brightness/index.md
Comment thread files/en-us/web/css/filter-function/brightness/index.md
@estelle estelle requested a review from dipikabh March 20, 2023 15:39
Copy link
Copy Markdown
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements to this page 👍

@dipikabh dipikabh merged commit be8cde8 into mdn:main Mar 21, 2023
@estelle estelle deleted the brightness branch July 14, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants