chore(lint): run lint after lint:fix when files provided#29690
Merged
caugner merged 2 commits intoMay 22, 2026
Conversation
github-actions
Bot
added
infra
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
2 tasks
Contributor
Author
|
System file check failed because I changed the lint/fix.js 🫠 |
caugner
reviewed
May 18, 2026
caugner
added
the
meeting agenda
caugner
requested changes
May 22, 2026
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
caugner
approved these changes
May 22, 2026
caugner
left a comment
caugner
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tested locally.
On main:
% time npm run lint:fix http
> @mdn/browser-compat-data@7.3.16 lint:fix
> node lint/fix.js http
npm run lint:fix http 0.92s user 0.45s system 32% cpu 4.174 total
On this branch:
% time npm run lint:fix http
> @mdn/browser-compat-data@7.3.16 lint:fix
> node lint/fix.js http
Loading and checking files...
Testing browser data...
Testing feature data...
Testing all features together...
All data passed linting!
Linters have some exceptions, please help us remove them!
Flag data has 2 exceptions
- api.Notification.requireInteraction
- api.Window.dump
Obsolete has 1 exception
- html.elements.track.kind.descriptions
npm run lint:fix http 1.30s user 0.49s system 80% cpu 2.217 total
This increase is runtime is acceptable and fine.
caugner
changed the title
lint after lint:fix when files provided
Contributor
Author
|
@caugner Thanks , but if you feel like this needs be addressed perhaps we can open a new issue and work on a fix for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
npm run lint:fixso it exits with a failure when unfixable lint errors remain after the fixer runs.Previously,
lint:fixcould successfully apply available fixes and exit0, even when a follow-upnpm run lintwould still fail on the same target files. This made the command report success for cases it could not fully fix.The fix reuses the normal lint pass after running the existing fixers and exits non-zero when lint errors remain.
Fixes #29615.
Validation
npm run lint:fix -- http/headers/X-Frame-Options.jsonnpm run lint -- http/headers/X-Frame-Options.jsonspec_urlcase from Fixer does not report "Marked as standard_track, but missing required spec_url" #29615 and confirmedlint:fixnow exits with failure when the remaining lint error is unfixable.npm run formatnpm run lintNODE_ENVshell syntax.