Skip to content

chore: align release-please pre-1.0 versioning with org policy - #52

Merged
mashkovd merged 1 commit into
mainfrom
chore/align-release-please-versioning
May 17, 2026
Merged

mashkovd merged 1 commit into
mainfrom
chore/align-release-please-versioning

Conversation

@mashkovd

Copy link
Copy Markdown
Member

Summary

  • Remove bump-patch-for-minor-pre-major: true from release-please-config.json.
  • That flag made release-please treat feat commits as patch bumps while the version is below 1.0 — so the landing redesign (feat, PR feat(web): redesign landing page on the mctl design system #49) computed as 0.13.1 instead of 0.14.0.
  • This contradicts the org policy ("features bump MINOR"). With the flag gone, feat bumps minor as intended; bump-minor-pre-major stays so breaking changes bump minor (not major) pre-1.0.

Test plan

bump-patch-for-minor-pre-major made release-please treat feat commits as
patch bumps while the version is below 1.0, which contradicts the org
policy that features bump MINOR. Dropping it so feat commits bump the
minor version as intended; bump-minor-pre-major stays so breaking
changes bump minor rather than major pre-1.0.
@mashkovd
mashkovd merged commit e065777 into main May 17, 2026
4 checks passed
@mashkovd
mashkovd deleted the chore/align-release-please-versioning branch May 17, 2026 20:05
@claude

claude Bot commented May 17, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 15s —— View job


Trivial one-line config deletion — removes bump-patch-for-minor-pre-major: true from release-please-config.json. No logic change, no security or concurrency implications. The PR description accurately explains the before/after versioning behaviour.

0 P1 · 0 P2 · 0 P3 — no findings, good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants