Repository navigation
Conversation
Replace the "github ↗" text anchor in the ui_topbar template with a compact inline SVG GitHub mark (Invertocat, 16x16, fill=currentColor). The SVG inherits link color from .topbar a via currentColor, so it adapts to light/dark theme changes without new CSS rules. The anchor gains aria-label="GitHub" and title="GitHub" for accessibility, and the SVG carries aria-hidden="true". The footer "source" link and the lite topbar constant are unchanged. Update chrome_test.go to assert aria-label="GitHub" is present in the full-page render. Proposal: platform-gitops/agents-state/mctl-telegram/proposals/issue-154-nav-replace-github-text-link-with-a-gith/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude finished @mashkovd's task in 1m 15s —— View job Code Review
Findings: 0 P1, 0 P2, 1 P3
Verdict: Approved. No P1/P2 findings (1 P3). The SVG is the correct GitHub mark, accessibility attributes ( |
Addresses the P3 review nit on #157: the github-icon link had class gh-link with no matching CSS rule. Add a targeted rule that vertically centers the inline SVG within the topbar nav (display:inline-flex).
|
Claude finished @mashkovd's task in 58s —— View job Code Review
Findings: 0 P1, 0 P2, 0 P3 The synchronize commit ( All three changes look correct:
Verdict: Approved. No P1/P2/P3 findings. Good to merge. |
…t-link-with-a-gith
mashkovd
deleted the
feat/agents-issue-154-nav-replace-github-text-link-with-a-gith
branch
May 23, 2026 10:31
This was referenced May 24, 2026
This was referenced Jun 1, 2026
This was referenced Jun 7, 2026
This was referenced Jun 14, 2026
This was referenced Jun 22, 2026
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements accepted proposal
mctl-telegram/issue-154-nav-replace-github-text-link-with-a-gith.Spec: https://github.com/mctlhq/mctl-gitops/tree/main/platform-gitops/agents-state/mctl-telegram/proposals/issue-154-nav-replace-github-text-link-with-a-gith/
Generated by mctl-agents Tier 2 implementer. Review carefully — this PR was opened automatically and the spec may have gaps.
Closes #154