Skip to content

feat(agents): issue-154-nav-replace-github-text-link-with-a-gith - #157

Merged
mashkovd merged 4 commits into
mainfrom
feat/agents-issue-154-nav-replace-github-text-link-with-a-gith
May 23, 2026
Merged

mashkovd merged 4 commits into
mainfrom
feat/agents-issue-154-nav-replace-github-text-link-with-a-gith

Conversation

@mashkovd

Copy link
Copy Markdown
Member

Implements accepted proposal mctl-telegram/issue-154-nav-replace-github-text-link-with-a-gith.

Spec: https://github.com/mctlhq/mctl-gitops/tree/main/platform-gitops/agents-state/mctl-telegram/proposals/issue-154-nav-replace-github-text-link-with-a-gith/

Generated by mctl-agents Tier 2 implementer. Review carefully — this PR was opened automatically and the spec may have gaps.

Closes #154

Replace the "github ↗" text anchor in the ui_topbar template with a
compact inline SVG GitHub mark (Invertocat, 16x16, fill=currentColor).
The SVG inherits link color from .topbar a via currentColor, so it
adapts to light/dark theme changes without new CSS rules. The anchor
gains aria-label="GitHub" and title="GitHub" for accessibility, and the
SVG carries aria-hidden="true". The footer "source" link and the lite
topbar constant are unchanged.

Update chrome_test.go to assert aria-label="GitHub" is present in the
full-page render.

Proposal: platform-gitops/agents-state/mctl-telegram/proposals/issue-154-nav-replace-github-text-link-with-a-gith/

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@claude

claude Bot commented May 22, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 1m 15s —— View job


Code Review

  • Read diff and changed files
  • Check CSS for new class
  • Post findings and verdict

Findings: 0 P1, 0 P2, 1 P3

  • P3 (chrome.go:70): class="gh-link" has no matching rule in components.css. The icon renders fine via .topbar a inheritance — either add a targeted rule or drop the unused class.

Verdict: Approved. No P1/P2 findings (1 P3). The SVG is the correct GitHub mark, accessibility attributes (aria-label, aria-hidden) are properly applied, rel="noopener" is preserved, and the test covers the new element.

Comment thread internal/ui/chrome.go
claude[bot]
claude Bot previously approved these changes May 22, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No P1/P2 findings (1 P3). Good to merge.

@mctl-claude-remote mctl-claude-remote Bot added steward:owned pr-steward owned steward:escalated pr-steward escalated to a human labels May 23, 2026
mashkovd added 2 commits May 23, 2026 10:26
Addresses the P3 review nit on #157: the github-icon link had class
gh-link with no matching CSS rule. Add a targeted rule that vertically
centers the inline SVG within the topbar nav (display:inline-flex).
@claude

claude Bot commented May 23, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 58s —— View job


Code Review

  • Gather context and read diff
  • Review changed files
  • Submit verdict

Findings: 0 P1, 0 P2, 0 P3

The synchronize commit (30e129f) resolves the previous P3: .topbar a.gh-link { display: inline-flex; align-items: center; } is now present in components.css, properly aligning the SVG icon in the nav flow.

All three changes look correct:

  • chrome.go: SVG is the canonical GitHub mark, accessibility attributes (aria-label, aria-hidden) applied correctly, rel="noopener" preserved.
  • components.css: inline-flex keeps the link inline in the nav; align-items: center aligns the icon to the text baseline.
  • chrome_test.go: assertion on aria-label="GitHub" confirms the element is present.

Verdict: Approved. No P1/P2/P3 findings. Good to merge.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No P1/P2 findings (0 P3). Previous P3 (missing .gh-link rule) fixed with inline-flex alignment. Good to merge.

@mashkovd mashkovd removed the steward:escalated pr-steward escalated to a human label May 23, 2026
@mctl-claude-remote mctl-claude-remote Bot added the steward:escalated pr-steward escalated to a human label May 23, 2026
@mashkovd mashkovd removed the steward:escalated pr-steward escalated to a human label May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

steward:escalated pr-steward escalated to a human steward:owned pr-steward owned steward:update-attempt-1 pr-steward update-branch attempt 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nav: replace "github ↗" text link with a GitHub icon so the top nav fits on one line on mobile

1 participant