Skip to content

feat(agents): issue-35-fix-web-city-notes-section-layout-overfl - #39

Merged
mctl-claude-remote[bot] merged 1 commit into
mainfrom
feat/agents-issue-35-fix-web-city-notes-section-layout-overfl
Jun 3, 2026
Merged

mctl-claude-remote[bot] merged 1 commit into
mainfrom
feat/agents-issue-35-fix-web-city-notes-section-layout-overfl

Conversation

@mashkovd

@mashkovd mashkovd commented Jun 3, 2026

Copy link
Copy Markdown
Member

Implements accepted proposal mctl-pairdesk/issue-35-fix-web-city-notes-section-layout-overfl.

Spec: https://github.com/mctlhq/mctl-gitops/tree/main/platform-gitops/agents-state/mctl-pairdesk/proposals/issue-35-fix-web-city-notes-section-layout-overfl/

Generated by mctl-agents Tier 2 implementer. Review carefully — this PR was opened automatically and the spec may have gaps.

Closes #35

…step 3

Add a Notes label before the notes textarea in step 3 and move the
pd-form-sub helper paragraph to follow it, matching the intended
label -> hint -> field structure. Fix pd-form-sub top margin from
-8px to 0 to eliminate negative-margin overlap against non-label
preceding elements.

Proposal: platform-gitops/agents-state/mctl-pairdesk/proposals/issue-35-fix-web-city-notes-section-layout-overfl/
@claude

claude Bot commented Jun 3, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 1m 4s —— View job


PR Review: issue-35-fix-web-city-notes-section-layout-overflow

Status: ✅ Approved

Analysis:
This PR fixes the layout overflow in the CreateOrder step 3 form by making two coordinated changes:

  1. web/src/screens/CreateOrder.tsx (line 304): Added missing pd-label span for "Notes" field, matching the structure of the "City" label above it.
  2. web/src/styles.css (line 921): Fixed .pd-form-sub margin from margin: -8px 0 12px; to margin: 0 0 10px; to eliminate the negative top margin that was causing layout overflow.

Findings:

  • No P1/P2 issues identified
  • Change follows existing form label patterns in the codebase
  • CI passed successfully
  • Straightforward CSS/HTML layout fix with no security, logic, or concurrency implications

Verdict: No P1/P2 findings. Good to merge. ✅


@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No P1/P2 findings. Straightforward layout fix adding missing Notes label and correcting form-sub margins. Good to merge.

@mctl-claude-remote mctl-claude-remote Bot added the steward:owned pr-steward owned label Jun 3, 2026
@mctl-claude-remote
mctl-claude-remote Bot merged commit 4bc1b8b into main Jun 3, 2026
5 checks passed
@mctl-claude-remote
mctl-claude-remote Bot deleted the feat/agents-issue-35-fix-web-city-notes-section-layout-overfl branch June 3, 2026 20:19
@mctl-claude-remote mctl-claude-remote Bot added steward:merged pr-steward merged and removed steward:owned pr-steward owned labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

steward:merged pr-steward merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(web): CITY & notes section layout overflow in Create-Order step 3

1 participant