Repository navigation
fix(workflows): bump mctl-agents image to 1.7.0 in implement CWFT - #70
Merged
Merged
Conversation
The implementer step was pinned to mctl-agents:1.2.0, but the orchestrator.run_implementer module was only added in mctl-agents PR #10 (commit f8155de) — first published as tag 1.7.0. Running 1.2.0 crashes immediately with: /usr/local/bin/python: No module named orchestrator.run_implementer Verified by submitting a Workflow against the 1.2.0-pinned CWFT on the preview cluster: implement step exits 1 with the ImportError above. The misleading comment that called 1.2.0 "first tag with gh CLI baked in" was also incorrect — 1.2.0 was just the first non-trivial agents release. Updated the comment to point at the actual gating dependency (the run_implementer module). After this lands, ArgoCD syncs the new image tag and the next Workflow referencing mctl-agents-implement starts a real implementer run.
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The implement step pins `mctl-agents:1.2.0`, but the `orchestrator.run_implementer` module that the step actually invokes was only added in mctl-agents PR #10 (released as tag 1.7.0). Running 1.2.0 crashes immediately:
```
/usr/local/bin/python: No module named orchestrator.run_implementer
```
Verified live on the preview cluster — a Workflow against the 1.2.0-pinned CWFT exits 1 with this ImportError at run-implementer.
Fix
Test plan