Repository navigation
chore(mctl-agents): bump 1.4.0 → 1.7.0 (3 features in one cycle) - #66
Merged
Merged
Conversation
Single bump skipping the 1.5.0 / 1.6.0 intermediates — all three features land atomically with one ArgoCD sync. There is no functional benefit to a staged rollout (each feature is net-additive and gated by env: tier-2 needs GITHUB_TOKEN which isn't set yet, github-fallback in mctl-docs needs the same, digest rotation only fires when there are >8 weeks of digests on disk and we currently have one), so a single PR saves us 2× (Copilot review + ArgoCD sync) cycles. The 1.7.0 image carries: - mctl-agents#8 (1.5.0) — mctl-docs falls back to GitHub REST API via WebFetch / curl when sibling clones are absent (ports the feature from #1 to English main; Copilot autonomously fixed jq filter + deprecated diff media type). - mctl-agents#9 (1.6.0) — orchestrator rotates _mentor/digest/ files older than 8 ISO weeks into digest/archive/. Deterministic, zero-token (ports #3; Copilot added an OSError guard). - mctl-agents#10 (1.7.0) — Tier 2 implementer scaffold: orchestrator/run_implementer.py + 7 implementer.md sub-agents + Dockerfile gh-CLI install + IMPLEMENTER_BUDGET_USD=$3 (ports #2; Copilot fixed hardcoded developer path, finally-block cleanup semantics, and a global os.environ mutation that leaked between proposals). Tier-2 scaffold is dormant until follow-up infra lands separately: - Vault: secret/platform/mctl-agents/github-token (PAT, repo write on mctlhq/*) - ExternalSecret update to surface as GITHUB_TOKEN env - New CWT cwft-mctl-agents-tier2.yaml invoking orchestrator.run_implementer - MCP tool mctl_trigger_implementer in mctl-api SERVICE_AGENT_BUDGET_USD stays $5.00. No env changes.
Member
Author
|
@copilot review |
Review: ✅ LGTM — single-line bump, no issues introduced Change What I checked
Verdict: Change is correct, minimal, and the PR description thoroughly justifies skipping the 1.5.0 / 1.6.0 intermediates. Safe to merge. |
7 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single bump skipping the 1.5.0 / 1.6.0 intermediates — all three features land atomically with one ArgoCD sync.
Why one PR not three
There is no functional benefit to a staged rollout — each feature is net-additive and gated by env / state:
GITHUB_TOKENis set. Without the token, mctl-docs degrades gracefully to "no signal: rate-limited" (instead of "path missing"); behaviour is otherwise unchanged._mentor/digest/has >8 weeks of files. Currently 1 file on disk → no-op.github-tokenkey, ExternalSecret update, new CWTcwft-mctl-agents-tier2.yaml, MCP toolmctl_trigger_implementer). The Tier 1 daily run does not call into the implementer.A staged 1.5 → 1.6 → 1.7 rollout would burn 2× extra cycles (Copilot review + ArgoCD sync per bump) for zero risk reduction.
What 1.7.0 carries
mctl-agents#8— mctl-docs falls back to GitHub REST API via WebFetch / curl when sibling clones are absent. Ports deploy: liberty/test #1 from Russian-base to English; Copilot SWE Agent autonomously fixed thejqorphan-commit filter (<= 1→== 1) and updated the deprecated diff media type.mctl-agents#9— orchestrator rotates_mentor/digest/files older than 8 ISO weeks intodigest/archive/. Deterministic, zero-token. Ports deploy: libertex/nginx #3 from Russian-base; Copilot added anOSErrorguard so a permission/NotADirectoryErroronarchive/doesn't abort the whole mentor run.mctl-agents#10— Tier 2 implementer scaffold (orchestrator/run_implementer.py+ 7implementer.mdsub-agents + DockerfileghCLI install +IMPLEMENTER_BUDGET_USD=$3.00). Ports deploy: developers/test #2 from Russian-base; Copilot fixed three real bugs: hardcoded developer path asDEFAULT_STATE_DIR,finallyblock always deleting clone dir despite "keep on failure" comment, and a globalos.environ["PROPOSAL_DIR"]mutation that leaked between proposals.Out of scope (operational follow-ups for tier-2 activation)
secret/platform/mctl-agents/github-token(fine-grained PAT withrepowrite onmctlhq/*).mctl-agents-secretsto surface asGITHUB_TOKENenv in the workflow pod.cwft-mctl-agents-tier2.yamlmirroring-runbut invokingorchestrator.run_implementerwithservice/slugparameters.mctl_trigger_implementerinmctl-apifor on-demand triggers.Image readiness
Tag
1.7.0build: https://github.com/mctlhq/mctl-agents/actions/runs — completed:success.Test plan
mctl_trigger_mentor_onlyto smoke-test that the new mentor (with rotation) runs cleanly.