Repository navigation
fix(observability): rounding-safe threshold for login-stall alert - #311
Merged
Merged
Conversation
increase() extrapolates to a floating-point value, so a window with exactly two timeouts can interpolate just under the >= 2 boundary (e.g. 1.97) and silently fail to fire. > 1 is rounding-safe and semantically identical for whole-number counter increments. Addresses the P2 from the PR #310 review.
|
Claude finished @mashkovd's task in 29s —— View job The change is correct and the inline comment explains the rationale well. No P1/P2 findings, good to merge. |
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
MctlTelegramLoginSendCodeStallsfrom>= 2to> 1.Why
Addresses the P2 from the #310 review:
increase()returns a floating-point extrapolated value, so a window with exactly two timeouts can interpolate just under the boundary (e.g.1.97) and silently fail to fire>= 2.> 1is rounding-safe and semantically identical for whole-number counter increments.Test plan