Repository navigation
fix(mctl-telegram): wire Telegram OIDC client credentials - #233
Merged
Merged
Conversation
mctl-telegram 0.16.0 replaced the legacy Login Widget with Telegram's OpenID Connect flow. The service is fail-closed: it will not boot without TELEGRAM_OIDC_CLIENT_ID and TELEGRAM_OIDC_CLIENT_SECRET. Adds the OIDC client id as a plain env var (the @MCTL_AI_bot numeric id, not secret) and sources the client secret from Vault secret/platform/mctl-telegram/oauth (key oidc-client-secret) via the existing oauth ExternalSecret. TELEGRAM_LOGIN_BOT_USERNAME is left in place as harmless dead config; it will be removed in a follow-up.
|
Claude finished @mashkovd's task in 31s —— View job Trivial values change: one plain env var ( No P1/P2/P3 findings. Good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mctl-telegram 0.16.0 (just released) replaced the legacy Telegram Login Widget with Telegram's OpenID Connect flow. The service is fail-closed — it will not boot without the OIDC client credentials.
TELEGRAM_OIDC_CLIENT_IDenv (8568443430, the@MCTL_AI_botnumeric id — not a secret).TELEGRAM_OIDC_CLIENT_SECRETto thelabs-mctl-telegram-oauthExternalSecret, sourced from Vaultsecret/platform/mctl-telegram/oauthkeyoidc-client-secret.TELEGRAM_LOGIN_BOT_USERNAMEleft as harmless dead config (0.16.0 ignores it) — removed in a follow-up.Pairs with the
image.tagbump to0.16.0already onmain. Trivial values change.Test plan
TELEGRAM_OIDC_*boot error)