Skip to content

fix(mctl-telegram): force client-side apply for oauth ExternalSecret #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mashkovd merged 1 commit into from
May 17, 2026
Merged

fix(mctl-telegram): force client-side apply for oauth ExternalSecret #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions platform-gitops/helm-charts/base-service/templates/externalsecret-extra.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ metadata:
name: {{ $name }}
labels:
{{- include "base-service.labels" $ | nindent 4 }}
{{- with $es.annotations }}
annotations:
{{- range $k, $v := . }}
{{ $k }}: {{ $v | quote }}
{{- end }}
{{- end }}
spec:
refreshInterval: {{ $es.refreshInterval | default "1h" }}
secretStoreRef:
Expand Down
6 changes: 6 additions & 0 deletions platform-gitops/services/labs/mctl-telegram/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ extraExternalSecrets:
labs-mctl-telegram-oauth:
refreshInterval: 1h
targetSecret: labs-mctl-telegram-oauth
# Force ArgoCD client-side apply for this ExternalSecret. ArgoCD v3.3.8 with
# ServerSideApply + serverSideDiff fails to apply ExternalSecrets with
# "metadata.managedFields must be nil"; client-side apply bypasses that path.
# Remove once the platform-wide ArgoCD SSA bug is fixed (see tracking issue).
annotations:
argocd.argoproj.io/sync-options: ServerSideApply=false
data:
# Dedicated mctl-telegram JWT signing key. Previously OAUTH_JWT_SECRET was
# sourced from mctl-api's shared secret (secret/data/platform/mctl-api/oauth),
Expand Down