Skip to content

docs(vault): record the move of secret/teams/platform to platform/legacy - #1672

Merged
mashkovd merged 2 commits into
mainfrom
docs/vault-teams-platform-moved
Oct 11, 2026
Merged

mashkovd merged 2 commits into
mainfrom
docs/vault-teams-platform-moved

Conversation

@mashkovd

@mashkovd mashkovd commented Oct 4, 2026

Copy link
Copy Markdown
Member

Docs only. This records the owner-approved move of the legacy secret/teams/platform/ folder to secret/platform/legacy/teams-platform/ in docs/runbooks/vault-human-auth.md.

Why. Since #1655, tenants can list the folder names directly under secret/teams/. A legacy platform folder sat there next to the tenant folders, so every tenant could see its name.

What moved, on 2026-10-04 at 21:31Z, by an admin token:

  • teams/platform/mctl-agent/database → platform/legacy/teams-platform/mctl-agent/database (latest version)
  • teams/platform/mctl-agent/tokens → platform/legacy/teams-platform/mctl-agent/tokens (latest version)

Checks:

  • Before the move: no references. Checked with gh search code across the org's default branches, in the live cluster (ExternalSecrets and their stores, workloads, ConfigMaps, Argo workflow templates, pods), and in every Vault policy and Kubernetes auth role.
  • The copies match. A SHA-256 of the data was compared on both sides, and no value was printed.
  • The old versions are gone. The old paths were removed with vault kv metadata delete, and every old version now returns 404.
  • After the move:
    • teams/ lists only tenants.
    • An admin can read the copies.
    • A human-tenant-erpact token gets 403 on them.

The runbook also states that only tenant folders belong directly under teams/, and points to #1670 for per-tenant mounts.

🤖 Generated with Claude Code

https://claude.ai/code/session_01D1kGUJMWeA8hyhQuxKuHd2

Tenants can list teams/ since #1655, which exposed the name of a legacy platform folder kept next to the tenant folders. Record what was moved where and how it was verified, and state that only tenant folders belong directly under teams/.
Copilot AI balanced review requested due to automatic review settings October 4, 2026 21:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Antigravity (agy) review — informational

Model: gemini-3.8-flash-medium · commit a934374.

No significant issues found.

@claude

claude Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 28s —— View job


Review complete ✅

  • Gather context (PR body, diff, CLAUDE.md conventions)
  • Review diff for correctness/security issues
  • Submit verdict

Verdict: Approved. This is a docs-only change — two new sections added to docs/runbooks/vault-human-auth.md recording a completed Vault secret migration (secret/teams/platform/ → secret/platform/legacy/teams-platform/) and a clarifying note that only tenant folders belong directly under teams/. No manifests, Helm values, RBAC, or workflow files are touched, and the diff contains only paths/dates/process description — no secret values. Falls under the "trivial diff" criteria (docs/comments), so approved per the automated review policy.

The audit device went live at 20:00Z (#1661), so reads before the move are observable from then on; record the query and its result in place of the claim that no audit device exists.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only change recording a completed Vault secret migration; no code, manifests, or secret values touched.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Antigravity (agy) review — informational

Model: gemini-3.8-flash-medium · commit 8016d2f.

No significant issues found.

@claude

claude Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Claude finished @mashkovd's task in 27s —— View job


Review complete ✅

  • Gather context (PR description, diff, CLAUDE.md)
  • Review diff for correctness/security/operational safety
  • Post verdict

Verdict: Approved. This is a docs-only change (docs/runbooks/vault-human-auth.md, +45/-0) recording an already-completed Vault secret move (secret/teams/platform/ → secret/platform/legacy/teams-platform/). No manifests, Helm values, RBAC, or ArgoCD specs are touched, and no secret values appear in the diff — only paths, a SHA-256-comparison description, and audit-log query results. Content is internally consistent: the table of moved paths matches the prose, and the stated access checks (tenant 403, admin 200, 404 on old paths) align with the stated goal.

Approved per gh api .../reviews --method POST -f event="APPROVE" bound to commit 8016d2f1.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only change (runbook update recording an already-completed Vault secret move); no code/config/manifest changes, no secrets exposed in the diff.

@mashkovd
mashkovd merged commit 10b4a1a into main Oct 11, 2026
24 checks passed
@mashkovd
mashkovd deleted the docs/vault-teams-platform-moved branch October 11, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants