Repository navigation
fix(labs/trading-data): bump to 0.2.4 — Etherscan V2 API - #141
Merged
Merged
Conversation
End-to-end smoke against 0.2.3 returned `{"error":{"code":
"etherscan_error","message":"NOTOK"}}` from etherscan_gas_snapshot.
Free-tier keys created at etherscan.io after the V2 multichain
migration only work against `/v2/api?chainid=...`; the legacy
`/api` endpoint rejects them with NOTOK.
mctl-trading-data 0.2.4 (commit e057505) switches to V2 + chainid=1.
No public response shape change.
Member
Author
|
@codex review |
|
To use Codex here, create an environment for this repo. |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
End-to-end smoke against 0.2.3 returned the following from
etherscan_gas_snapshot:{"error":{"code":"etherscan_error","message":"NOTOK"}}NOTOK is Etherscan's catch-all for "API key valid but request not accepted". Free-tier keys created at
etherscan.io/myapikeyafter the V2 multichain migration only work against/v2/api?chainid=...; the legacy/api(V1) endpoint rejects them with NOTOK.mctl-trading-data 0.2.4 (commit
e057505, image already published) switches to V2 +chainid=1(Ethereum mainnet) for bothetherscan_gas_snapshotandetherscan_whale_transactions. No public response shape change — V2 still returns{status, message, result}.Test plan
etherscan_gas_snapshotreturnssafe_gwei/standard_gwei/fast_gweipopulatedetherscan_whale_transactionsreturns recent Vitalik transactions or empty list@codex reviewclean