Repository navigation
fix(mctl-agent): correct TELEGRAM_CHAT_ID to operator user id 210408407 - #112
Merged
Merged
Conversation
PR #99 used 8568443430 thinking it was the admins-openclaw chat ID, but in 1:1 bot chats Telegram uses the human participant's user id — 8568443430 turned out to be a bot account, surfacing as '403 Forbidden: bots can't send messages to bots' once we migrated to @MCTL_AI_bot in PR #111. Operator confirmed via getUpdates that the correct chat_id for the mctl_admins chat is 210408407 (their own Telegram user id, identical to the previous mctl_labs chat — same user, different bot).
Member
Author
|
@codex review |
Member
Author
|
@copilot review |
The change is correct and minimal. Here's my review: What changed (commit
No concerns:
|
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TELEGRAM_CHAT_ID: 8568443430with210408407(operator's Telegram user id).Why
PR #99 set the chat id to
8568443430as the admins-openclaw target, but that value turns out to be a bot account, not a human chat. After migrating the bot identity to@MCTL_AI_botin PR #111, Telegram returned403 Forbidden: bots can't send messages to botson every send.Operator verified via
getUpdatesthat the correct chat id for the 1:1 chat with@MCTL_AI_botis210408407— the same id used previously for the@mctl_me_botchat, because in 1:1 bot conversations Telegram identifies the chat by the human participant's user id (constant across bots).Test plan
admins-mctl-agentmctl-agent-secretsso ESO repopulates the template (TELEGRAM_CHAT_IDlives intargetTemplateData)kubectl -n admins rollout restart deploy/admins-mctl-agent-base-servicePOST https://agent.mctl.ai/api/v1/alerts(namespace=ovk) → message arrives inmctl_adminschat with@MCTL_AI_bot