Skip to content

chore(workflows): bump mctl-agents shepherd image to 1.10.0 - #100

Merged
mashkovd merged 1 commit into
mainfrom
chore/bump-shepherd-image-1-10-0
May 2, 2026
Merged

mashkovd merged 1 commit into
mainfrom
chore/bump-shepherd-image-1-10-0

Conversation

@mashkovd

@mashkovd mashkovd commented May 2, 2026

Copy link
Copy Markdown
Member

Summary

Test plan

mctl-agents PR #13 landed dead-letter `in-progress` recovery (closed
unmerged PRs now flip to `rejected` instead of stalling forever).

Reference incident: mctl-openclaw/upgrade-to-2026-4-27 (PR
mctlhq/mctl-openclaw#15, closed 2026-04-30, manually reconciled via
mctl-gitops PR #97 before the fix landed in 1.10.0).

Backward-compatible MINOR bump per semver — steady-state behaviour
for `implemented`/`review-fixing` proposals is unchanged.
@mashkovd

mashkovd commented May 2, 2026

Copy link
Copy Markdown
Member Author

@codex review

@mashkovd

mashkovd commented May 2, 2026

Copy link
Copy Markdown
Member Author

@copilot review

Copilot AI commented May 2, 2026

Copy link
Copy Markdown

@copilot review

Here's my review of the changes in this PR (06768c5):

What changed

No issues found

  • Scope is minimal: only the image ref and its associated comments change; no logic, env vars, resource requests, volumes, continueOn settings, or synchronization mutex are touched
  • imagePullPolicy: IfNotPresent is correctly retained — appropriate for a pinned tag
  • Comment quality is an improvement: removes the confusing "intentional ImagePullBackOff" note and documents why 1.10.0 is needed (dead-letter recovery, incident traceback)
  • Tag pinning uses a mutable semver tag (:1.10.0) rather than a SHA digest — this is consistent with the existing pattern throughout the file and repo, so it's not a regression introduced here

Minor observation (not a blocker): Using an immutable image digest (@sha256:…) instead of a mutable tag would harden the deploy against accidental tag rebasing, but adopting that pattern would be a repo-wide convention change, not in scope for this bump.

Overall: LGTM — correct, minimal, well-documented change.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mashkovd
mashkovd merged commit a175158 into main May 2, 2026
@mashkovd
mashkovd deleted the chore/bump-shepherd-image-1-10-0 branch May 2, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants