Repository navigation
feat(agents): mcp-agents-tools - #7
Conversation
Proposal: platform-gitops/agents-state/mctl-docs/proposals/mcp-agents-tools/
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c37f81edd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | `mctl_trigger_agents_run` | Full pipeline — all service-agents + mentor digest | `workflow_name` | | ||
| | `mctl_trigger_mentor_only` | Mentor weekly digest only | `workflow_name` | | ||
| | `mctl_trigger_single_service` | One service-agent cycle | `workflow_name` | | ||
| | `mctl_list_recent_agent_runs` | List ≤10 recent pipeline runs from audit log | JSON array | |
There was a problem hiding this comment.
mctl_list_recent_agent_runs summary
The tool summary says mctl_list_recent_agent_runs returns a JSON array, but the detailed section later defines a wrapped object ({ "items": [...], "count": N }). This mismatch can cause callers to deserialize the response incorrectly when they rely on the summary table for quick integration, so the summary return type should be updated to match the documented schema.
Useful? React with 👍 / 👎.
| | Tool | Purpose | Returns | | ||
| |---|---|---| |
There was a problem hiding this comment.
This new section introduces five tools without the Type annotation used everywhere else in this reference, despite the page contract stating each tool is classified for safety semantics. In practice, this makes it harder for MCP clients (and humans) to distinguish the one read tool from destructive/write triggers at a glance, increasing the chance of invoking a mutating action unintentionally.
Useful? React with 👍 / 👎.
Corrects the return-shape description for mctl_list_recent_agent_runs in the
tool summary table from "JSON array" to the actual object shape
{ "items": [...], "count": N }, matching the detailed section below.
Proposal: platform-gitops/agents-state/mctl-docs/proposals/mcp-agents-tools/
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22255ab9c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Tool | Purpose | Returns | | ||
| |---|---|---| | ||
| | `mctl_trigger_agents_run` | Full pipeline — all service-agents + mentor digest | `workflow_name` | | ||
| | `mctl_trigger_mentor_only` | Mentor weekly digest only | `workflow_name` | | ||
| | `mctl_trigger_single_service` | One service-agent cycle | `workflow_name` | | ||
| | `mctl_list_recent_agent_runs` | List ≤10 recent pipeline runs from audit log | `{ "items": [...], "count": N }` | | ||
| | `mctl_trigger_implementer` | Tier 2: open PRs for accepted proposals | `workflow_name` | |
There was a problem hiding this comment.
The new mctl-agents tools are introduced in a custom summary table that omits the Type classification used everywhere else in this reference (Read/Write/Destructive), even though these operations trigger workflows and mutate platform state. Because this page is the canonical MCP tool reference and explicitly says tools are annotated by behavior, leaving these five unclassified makes risk handling ambiguous for readers and agent wrappers that use this doc to decide confirmation behavior.
Useful? React with 👍 / 👎.
Implements accepted proposal
mctl-docs/mcp-agents-tools.Spec: https://github.com/mctlhq/mctl-gitops/tree/main/platform-gitops/agents-state/mctl-docs/proposals/mcp-agents-tools/
Generated by mctl-agents Tier 2 implementer. Review carefully — this PR was opened automatically and the spec may have gaps.