Repository navigation
ci: make Claude review submit a formal PR approval - #92
Merged
Merged
Conversation
Branch protection requires one approving review to merge, but the reviewer only posted a summary comment, never a real gh pr review. That made every clean PR structurally BLOCKED, requiring --admin to merge. Switch the verdict to gh pr review --approve/--request-changes, matching the pattern already proven in mctl-telegram#119.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainbranch ruleset requiresrequired_approving_review_count: 1, butclaude-review.ymlonly posted a top-level summary comment — never a formalgh pr review. Every clean PR was structurallyBLOCKED/REVIEW_REQUIRED, forcing--adminto merge (hit this on fix(gitops): reset diverged local cache instead of failing ff-only pull #88/chore(main): release 4.21.1 #89/fix: bump Docker builder image to golang:1.26-alpine #90/chore(main): release 4.21.2 #91 today).gh pr review --approve/--request-changesas the actual verdict — same pattern already shipped inmctl-telegram#119.Bash(gh pr review:*)to--allowedToolsand a "Reset git state before fallback" step (also from the telegram template) so the fallback pass starts clean.Known gotcha
This PR edits
claude-review.ymlitself, so its own Claude review step will fail 401 (the GitHub App rejects the OIDC token when the workflow file differs from the default branch). Expect to merge this one via--admin; the new approve/request-changes behavior takes effect starting with the next PR in this repo.Test plan
gh pr review --approve(not just a comment) and merges without--admin