Repository navigation
fix(auth): extend OAuth access token TTL from 1h to 7d - #49
Merged
Merged
Conversation
mctl-api stores refresh tokens in-memory (sync.Map). Any pod restart clears them, breaking openclaw MCP connections after 1h (access token expiry). With a 7-day TTL the connection survives routine deploys. Proper fix (persist refresh tokens in Postgres) deferred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccessTokenTTLfromtime.Hourto7 * 24 * time.Hoursync.Map) — any pod restart clears themRoot cause
OAuthServer.refreshTokensis async.Map(in-memory).RefreshAccessTokenusesloadAndDelete— refresh token is single-use and not persisted. Pod restart = all refresh tokens gone. After the access token expires (was 1h), openclaw cannot refresh and shows "Not connected".Tradeoff
A compromised access token is valid for 7 days instead of 1h. Proper fix (persist refresh tokens in PostgreSQL) is deferred.
Test plan
go build ./...