Repository navigation
operations: mctl-agents-investigate drops agent_image/agent_version (release pin is dead) and needs loop-id params #372
Description
Problem
StripUndeclared (internal/api/handlers_write.go:83) silently drops every operation parameter the registry does not declare. For mctl-agents-investigate, the registry (internal/operations/registry.go:649-661) declares only issue_url, work_item_id and execution_id.
- The investigator release pin is dead today. The DevLoop resolves the pinned
issue-investigatorrelease and sendsagent_imageandagent_version(mctl-agentsorchestrator/temporal/workflows/dev_loop.py, investigate step). The CWFT declares both parameters, but mctl-api strips them, so every investigate run uses the CWFT's default image. Registry promotions and rollbacks of the investigator therefore have no effect on DevLoop runs. - Loop-identity params for mctl-agents#461 and chore(main): release 4.61.0 #451. mctl-gitops is adding optional
temporal_workflow_id,temporal_run_idandexecution_request_idto the investigate CWFT. A dispatched loop isdev-loop-xr_*, not the issue-keyed id, so the investigator must learn the real loop id. They need the same declaration here, or they are dropped as well. human_input_responses(the DevLoop continuation) is dropped too. The CWFT does not declare it either, so that one is a gitops + mctl-api pair.
Fix
- Declare
agent_imageandagent_versionformctl-agents-investigate, with patterns matching the image-ref and<agent>@<version>shapes used elsewhere in the registry. Check the othermctl-agents-*operations that the DevLoop pins the same way. - After the gitops CWFT change lands (gitops first, fail-closed), declare
temporal_workflow_id,temporal_run_idandexecution_request_idas optional, followingwork_item_id/execution_id. - Add a test that every parameter the DevLoop sends for each operation is declared, or equivalently that none of them hits
dropped.
Refs mctlhq/mctl-agents#461, mctlhq/mctl-agents#451.
🤖 Generated with Claude Code
Activity
mashkovd commentedon Sep 23, 2026
Part 1 merged in #378: the DevLoop release pins
agent_image/agent_versionon investigate, implement, shepherd and incidents, withOmitWhenEmptyso unpinned callers keep the CWFT default.Still open here:
temporal_workflow_id,temporal_run_id,execution_request_id). The gitops half is merged (mctl-gitops#1345). Declare them here only after the mctl-agents release that teaches the investigator CLI those flags; otherwise the CLI exits on an unknown flag.human_input_responses. It needs the investigate CWFT declaration first.P3 follow-ups from the #378 review:
agent_versionwithoutagent_image, and when the image is a tag, require the version's semver to match it.!(OmitWhenEmpty && Default != "")overbuiltinOperations, and note on the field thatDefaultis ignored.incidents.py(~101-105) wrongly says mctl-api passes undeclared params through. Correct that comment.mashkovd commentedon Sep 24, 2026
Update after mctlhq/mctl-agents#487 (#461 option A, merged
b68291c): dispatched loops are now issue-keyed, so the rationale in point 2 ("a dispatched loop isdev-loop-xr_*") no longer holds.Consumers were checked before deciding what to retire, and the declaration should stay:
temporal_run_idis still what retires a same-id leftover (mctl-agents#451).execution_request_idis still sealed into the snapshot correlation.temporal_workflow_idis now derivable fromissue_url, but the investigator still prefers the loop's own id over its derivation. Keeping it declared costs nothing, and dropping it would silently break the correlation for any loop whose id is not derivable.Points 1 (
agent_image/agent_version) and 3 (human_input_responses) are unaffected.