Add reading mode (View > Enter Reading Mode / Mode lecture)#72
Merged
Conversation
Entering reading mode goes full-screen, hides the menu bar and the
editor pane, floats the project explorer in a small utility window
above the preview, and hides the LLM chat and all other side panels.
Exiting (via the top-right button or Escape) restores every panel and
divider position to its previous state.
- MarkNote.java: promote root/topBar to fields; add enter/exit reading
mode logic with floating Stage for the project explorer; add View menu
item; suppress JavaFX full-screen exit hint
- pom.xml: fix exec plugin config (split JVM args, use ${java.home},
commandlineArgs + workingDirectory); add git.commit.id.abbrev fallback;
enable native git for git-commit-id plugin
- i18n (6 files): add menu.view.readingMode and reading.mode.exit keys
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mcgivrer
reviewed
May 12, 2026
Owner
There was a problem hiding this comment.
Attention, le retour du "Mode Lecture" provoque quelques soucis lors de la restauration de la position et de l'état des panels.
Un bug est apparu, si on ferme l'Explorateur de projet en mode lecture, le contenu du panel disparaît et il est impossible de le ramener dans l'affichage standard.
… doc update - Fix project explorer showing blank after hide/detach/reading mode: restore panel center in DetachedPanelTab.hideWithoutDocking(), stop DockingManager from overwriting the close handler, add afterReattach() → refresh() in ProjectExplorerPanel - Add minimize/maximize toggle button (▾/▴) to BasePanel, hidden by default and enabled only in reading mode; collapses the floating explorer to its title bar using the actual rendered header height + OS chrome height - Save and restore all split-divider positions (editor/preview ratio, docking horizontal/vertical splits) when exiting reading mode; defer setDividerPositions to Platform.runLater so it applies after all rebuildLayout calls complete - Add Ctrl+Shift+P accelerator for Enter Reading Mode menu item - Update authors to Frédéric Delorme/JB Meyer in all 6 i18n locales - Update README and user-guide-en.md with Reading Mode section, keyboard shortcut, and feature description Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
I've checked your proposal and verified localy, I do not see any linked issue (an existing issue on the previous version must be tracked about Restoring Panels positions and states error). I validated it. |
Owner
|
I'll keep the branch open until further info confirming no bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entering reading mode goes full-screen, hides the menu bar and the editor pane, floats the project explorer in a small utility window above the preview, and hides the LLM chat and all other side panels. Exiting (via the top-right button or Escape) restores every panel and divider position to its previous state.