[BUG] Square brackets in job name crash execution

[drws]

Describe the bug.
If there are square brackets in a job's name, webchanges cannot complete a run.

Steps to reproduce.
Include a square bracket in a job's name and run webchanges.

Expected behavior.
Square brackets should be valid characters. Even if not, webchanges should fail gracefully, and should fail only for this particular job, while still completing all the other jobs in the run. Actually, since webchanges uses URL as an UID, all the jobs should complete, including the one with invalid character(s) in the name.

Version info.
v3.34.2

[mborsetti]

Hi @drws

Thanks for the report. Unfortunately, I cannot reproduce.

I tested these sample jobs and they run fine:

name: test [has square brackets]
url: https://www.google.com/
filters:
  - html2text

and

name: test [has square brackets]
url: https://www.google.com/
use_browser: true
filters:
  - html2text

and

name: test [has square brackets]
command: echo The time now is %time% UTC # Windows

Can you please send me more information on the actual job and the -vv log (or at least the relevant parts) to see what interaction is causing the behavior you're seeing and that I can't reproduce?

Thanks!

[drws]

Oops, it's a YAML-syntax non-issue of course. If the non-quoted string starts with brackets, it's a list. The YAML syntax is already well presented in webchanges docs so not much to do there. There's still an issue in webchanges though, because it crashes if it encounters such a string, with the errors being different in case of valid vs. invalid string representation of a list. Webchanges should probably check for any invalid YAML data (and warn about it, also possibly by job reporter(s) - if their settings are valid).

[mborsetti]

@drws Thank you for your contribution!

Will take a look at the error; most likely that directive is not checked for the value being a string.

I have been putting off implementing Pydantic or similar and this could be the push to do so!

Again, thanks!