Fetch contributions concurrently for faster all and graph commands#16
Merged
Fetch contributions concurrently for faster all and graph commands#16
Conversation
- Add fetchAllContributions() that fetches PRs, reviews, issues, and discussions in parallel using goroutines - Refactor handleAllCommand and handleGraphCommand to use shared helper - Make mock clients thread-safe with sync.Mutex for race-free tests - ~4x faster for commands that fetch multiple contribution types Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fetches PRs, reviews, issues, and discussions in parallel using goroutines, making
allandgraphcommands ~4x faster.Changes
fetchAllContributions()— shared helper that spawns 4 goroutines to fetch all contribution types concurrently, with mutex-protected result aggregationhandleAllCommandandhandleGraphCommand— refactored to use the shared concurrent helper, removing ~90 lines of duplicate sequential fetch codeMockGitHubClientandMockGraphQLClientnow usesync.Mutexfor race-free concurrent testingPerformance
Before: 4 sequential API calls (each with potential pagination)
After: 4 concurrent API calls — total wall time ≈ slowest single call
All 30 tests pass with
-race.