Wrong template values when is using `wt switch pr:<number>`

[robsonpeixoto]

Wrong template values when is using wt switch pr:<number>.

As you can se on the output below, the worktree_path is being the /tmp/wt/worktrunk and should be /tmp/wt/worktrunk.feat-issue-3922-list-sort and the branch should not be pr:3933.

Maybe the hooks should wait for the step of "translate" the PR number in a branch name.

❯ wt switch pr:3933 --verbose
○ user:mise-env source
  set -x
  mise -C "{{ worktree_path }}" set -E local COMPOSE_PROJECT_NAME={{ primary_worktree_path | basename | lower }}
○ user:mise-env result
  set -x
  mise -C "/tmp/wt/worktrunk" set -E local COMPOSE_PROJECT_NAME=worktrunk
○ pre-switch template variables:
  branch                = pr:3933
  worktree_path         = /tmp/wt/worktrunk
  worktree_name         = worktrunk
  commit                = (unset)
  short_commit          = (unset)
  upstream              = (unset)
  base                  = main
  base_worktree_path    = /tmp/wt/worktrunk
  target                = pr:3933
  target_worktree_path  = (unset)
  pr_number             = (unset)
  pr_url                = (unset)
  repo                  = worktrunk
  repo_path             = /tmp/wt/worktrunk
  owner                 = max-sixty
  remote_repo           = worktrunk
  primary_worktree_path = /tmp/wt/worktrunk
  default_branch        = main
  remote                = origin
  remote_url            = git@github.com:max-sixty/worktrunk.git
  cwd                   = /tmp/wt/worktrunk
  hook_type             = pre-switch
  hook_name             = mise-env
◎ Running pre-switch user:mise-env
  set -x
  mise -C "/tmp/wt/worktrunk" set -E local COMPOSE_PROJECT_NAME=worktrunk
+ mise -C /tmp/wt/worktrunk set -E local COMPOSE_PROJECT_NAME=worktrunk
◎ Fetching PR #3933...
  feat(list): add `[list] sort` for configurable row order (#3933)
  by @worktrunk-bot · open · feat/issue-3922-list-sort · https://github.com/max-sixty/worktrunk/pull/3933
◎ Fetching feat/issue-3922-list-sort from origin...
○ worktree-path source
  {{ repo_path }}/../{{ repo }}.{{ branch | sanitize }}
○ worktree-path result
  /tmp/wt/worktrunk/../worktrunk.feat-issue-3922-list-sort
○ user:mise-trust source
  set -x
  if mise trust --show -C {{ primary_worktree_path }} 2>/dev/null | grep -q ': trusted'; then
    mise trust -C "{{ worktree_path }}"
  fi
○ user:mise-trust result
  set -x
  if mise trust --show -C /tmp/wt/worktrunk 2>/dev/null | grep -q ': trusted'; then
    mise trust -C "/tmp/wt/worktrunk.feat-issue-3922-list-sort"
  fi
○ pre-start template variables:
  branch                = feat/issue-3922-list-sort
  worktree_path         = /tmp/wt/worktrunk.feat-issue-3922-list-sort
  worktree_name         = worktrunk.feat-issue-3922-list-sort
  commit                = fc63bae65de50f2ee38b5948821da9ee6fde2820
  short_commit          = fc63bae65
  upstream              = origin/feat/issue-3922-list-sort
  base                  = (unset)
  base_worktree_path    = (unset)
  target                = feat/issue-3922-list-sort
  target_worktree_path  = /tmp/wt/worktrunk.feat-issue-3922-list-sort
  pr_number             = (unset)
  pr_url                = (unset)
  repo                  = worktrunk
  repo_path             = /tmp/wt/worktrunk
  owner                 = max-sixty
  remote_repo           = worktrunk
  primary_worktree_path = /tmp/wt/worktrunk
  default_branch        = main
  remote                = origin
  remote_url            = git@github.com:max-sixty/worktrunk.git
  cwd                   = /tmp/wt/worktrunk.feat-issue-3922-list-sort
  hook_type             = pre-start
  hook_name             = mise-trust
◎ Running pre-start user:mise-trust
  set -x
  if mise trust --show -C /tmp/wt/worktrunk 2>/dev/null | grep -q ': trusted'; then
    mise trust -C "/tmp/wt/worktrunk.feat-issue-3922-list-sort"
  fi
+ mise trust --show -C /tmp/wt/worktrunk
+ grep -q : trusted
+ mise trust -C /tmp/wt/worktrunk.feat-issue-3922-list-sort
mise WARN  No untrusted config files found.
✓ Created worktree for feat/issue-3922-list-sort @ /tmp/wt/worktrunk.feat-issue-3922-list-sort
○ post-switch template variables:
  branch                = feat/issue-3922-list-sort
  worktree_path         = /tmp/wt/worktrunk.feat-issue-3922-list-sort
  worktree_name         = worktrunk.feat-issue-3922-list-sort
  commit                = fc63bae65de50f2ee38b5948821da9ee6fde2820
  short_commit          = fc63bae65
  upstream              = origin/feat/issue-3922-list-sort
  base                  = (unset)
  base_worktree_path    = (unset)
  target                = feat/issue-3922-list-sort
  target_worktree_path  = /tmp/wt/worktrunk.feat-issue-3922-list-sort
  pr_number             = (unset)
  pr_url                = (unset)
  repo                  = worktrunk
  repo_path             = /tmp/wt/worktrunk
  owner                 = max-sixty
  remote_repo           = worktrunk
  primary_worktree_path = /tmp/wt/worktrunk
  default_branch        = main
  remote                = origin
  remote_url            = git@github.com:max-sixty/worktrunk.git
  cwd                   = /tmp/wt/worktrunk.feat-issue-3922-list-sort
  hook_type             = post-switch
  hook_name             = herdr
○ post-start template variables:
  branch                = feat/issue-3922-list-sort
  worktree_path         = /tmp/wt/worktrunk.feat-issue-3922-list-sort
  worktree_name         = worktrunk.feat-issue-3922-list-sort
  commit                = fc63bae65de50f2ee38b5948821da9ee6fde2820
  short_commit          = fc63bae65
  upstream              = origin/feat/issue-3922-list-sort
  base                  = (unset)
  base_worktree_path    = (unset)
  target                = feat/issue-3922-list-sort
  target_worktree_path  = /tmp/wt/worktrunk.feat-issue-3922-list-sort
  pr_number             = (unset)
  pr_url                = (unset)
  repo                  = worktrunk
  repo_path             = /tmp/wt/worktrunk
  owner                 = max-sixty
  remote_repo           = worktrunk
  primary_worktree_path = /tmp/wt/worktrunk
  default_branch        = main
  remote                = origin
  remote_url            = git@github.com:max-sixty/worktrunk.git
  cwd                   = /tmp/wt/worktrunk.feat-issue-3922-list-sort
  hook_type             = post-start
  hook_name             = deps
◎ Running post-switch: herdr (user); post-start: deps & assets, docs-install, docs (project)
❯

Version used:

❯ wt --version
wt v0.75.0

[max-sixty]

@worktrunk-bot please triage this issue. The original triage run was stranded by the Tend 0.1.19 sandbox regression; Worktrunk now uses the fixed Tend 0.1.20 action.

This was written by Codex on behalf of max-sixty

[worktrunk-bot]

Thanks for the detailed --verbose dump — it shows two separate defects, and the second one isn't in the title.

1. pre-switch runs before the PR is resolved. pr:3933 is resolved through gh inside plan_switch, which runs after the hook — so branch and target carry the literal token, and target_worktree_path stays unset even when the PR's branch already has a worktree. Your read of the cause is right. This is the same bug wt switch - had in #2309; the fix there was to resolve the argument before building the hook context, and pr:/mr: is the one form that was left out because its branch name only exists on the forge.

2. pr_number and pr_url are unset in all four of your hook blocks. That's a second bug the dump exposes: they were read off the fork-PR creation path, which a same-repo PR never takes, so the common case never got them despite the help text promising them for post-switch / pre-start / post-start.

Both are fixed in #3941: the PR resolves once, before pre-switch, and its identity is carried through the plan to every switch hook.

worktree_path, though, is working as intended — and that part of the fix is a docs correction rather than a code change. On a switch that creates a worktree, the destination directory doesn't exist yet when pre-switch runs, so worktree_path stays on the source. The help text said "worktree_path is the destination" with no caveat, which is what led you here; #3941 makes it say which case is which. Your mise-env hook wants pre-start, which runs once in the newly created worktree with worktree_path pointing at it — exactly where your mise-trust hook already sits:

[pre-start]
mise-env = "mise -C {{ worktree_path }} set -E local COMPOSE_PROJECT_NAME={{ primary_worktree_path | basename | lower }}"

One behaviour change worth flagging: the forge lookup and its git fetch now happen before pre-switch runs, so a hook that aborts the switch aborts it after the PR was fetched. That's inherent — the branch name is the forge's answer.

Sources

• Resolution ordering: SwitchPipeline::run — resolve_ref_shortcut_target now precedes run_pre_switch_hooks, and its result is threaded into plan_switch so the forge is still queried once.
• The missing pr_* on same-repo PRs: resolve_remote_ref returns CreationMethod::Regular for a same-repo PR (switch.rs), while execute_switch used to read the number and URL only off CreationMethod::ForkRef.
• Prior art for the ordering rule: Inconsistent/missing variables in pre-switch hook triggered by wt switch - #2309 → fix(switch): resolve symbolic target (-, @, ^) before pre-switch hooks #2310, for - / @ / ^.
• Regression tests: test_switch_pr_same_repo_hooks_see_resolved_branch and an extended test_switch_pr_hooks_see_pr_vars, both of which fail on main (the pre-switch hook aborts the switch with undefined value).