Repository navigation
Pre-commit hooks no longer require Python 3.12 and mypy always checks as 3.12 - #1031
Merged
Merged
Conversation
[Medium impact] The PR appears safe to merge. SummaryRemoves the Python 3.12 requirement for Python-based pre-commit hooks while keeping mypy's target at Python 3.12.
Reviews (1) · Last reviewed commit: "Pre-commit hooks no longer require Pytho..." · Reviewed by Greptile |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 10046 10046
=========================================
Hits 10046 10046 ☔ View full report in Codecov by Harness. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What does this PR do?
pre-commit run -afailed for anyone without Python 3.12 installed, because.pre-commit-config.yamlpinned the hooks topython3.12. This removes the pin, so the hooks run with the Python that runs pre-commit (e.g. 3.12 or 3.14).To keep mypy results the same whatever that version is,
python_version = "3.12"is added to[tool.mypy]. The pre-commit note inCONTRIBUTING.rstis updated to match.Before submitting