feat: add boolean-to-string entrypoint with custom toString method#238
Open
tijnjh wants to merge 1 commit into
Open
feat: add boolean-to-string entrypoint with custom toString method#238tijnjh wants to merge 1 commit into
tijnjh wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new boolean-to-string entrypoint that narrows Boolean#toString() to the literal string output ("true" / "false"), and wires it into the package’s public entrypoints (including recommended) via the export map.
Changes:
- Add
src/entrypoints/boolean-to-string.d.tsto narrowBoolean#toString()to`${boolean}`. - Include the new entrypoint in
src/entrypoints/recommended.d.ts. - Export
./boolean-to-stringfrompackage.jsonso consumers can import it directly.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/entrypoints/recommended.d.ts | Includes the new boolean-to-string entrypoint in the recommended bundle. |
| src/entrypoints/boolean-to-string.d.ts | Adds a global Boolean interface augmentation narrowing toString() to `"true" |
| package.json | Adds a new ./boolean-to-string export pointing to the built artifacts in dist/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boolean#toString()returns'true' | 'false'instead ofstring