Add Array.isArray improvement#23
Open
phenomnomnominal wants to merge 4 commits into
Open
Conversation
timbuckley
reviewed
Feb 21, 2023
timbuckley
reviewed
Feb 21, 2023
| import "@total-typescript/ts-reset/array-includes"; | ||
| ``` | ||
|
|
||
| This rule improves on TypeScript's default `Array.isArray` behaviour. Without this rule enabled, TypeScript will not include `ReadonlyArray<Item>` when narrowing Array types. |
There was a problem hiding this comment.
Also I weakly suggest using American standard spelling, though I suspect Mr. Pocock will prefer yours. ;)
Suggested change
| This rule improves on TypeScript's default `Array.isArray` behaviour. Without this rule enabled, TypeScript will not include `ReadonlyArray<Item>` when narrowing Array types. | |
| This rule improves on TypeScript's default `Array.isArray` behavior. With this rule enabled, TypeScript will now include `ReadonlyArray<Item>` when narrowing Array types. |
Co-authored-by: Tim Buckley <timothypbuckley@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the annoying thing where
Array.isArraydoesn't correctly narrow ReadonlyArray!