expo integration

[roeycohen]

When adding this plugin to expo i'm getting the following errors:

...
> Task :react-native-async-storage_async-storage:javaPreCompileDebug
> Task :mattermost_react-native-emm:compileDebugKotlin
e: file:///home/expo/workingdir/build/node_modules/@mattermost/react-native-emm/android/src/newarch/java/com/EmmModule.kt:14:1 Class 'EmmModule' is not abstract and does not implement abstract base class member public abstract fun applyBlurEffect(radius: Double): Unit defined in com.mattermost.emm.NativeEmmSpec
e: file:///home/expo/workingdir/build/node_modules/@mattermost/react-native-emm/android/src/newarch/java/com/EmmModule.kt:104:3 'applyBlurEffect' overrides nothing
e: file:///home/expo/workingdir/build/node_modules/@mattermost/react-native-emm/android/src/newarch/java/com/EmmModule.kt:104:48 An overriding function is not allowed to specify default values for its parameters
> Task :mattermost_react-native-emm:compileDebugKotlin FAILED
> Task :app:mergeDebugResources
> Task :react-native-async-storage_async-storage:compileDebugJavaWithJavac
/home/expo/workingdir/build/node_modules/@react-native-async-storage/async-storage/android/src/main/java/com/reactnativecommunity/asyncstorage/AsyncStorageModule.java:84: warning: [removal] onCatalystInstanceDestroy() in NativeModule has been deprecated and marked for removal
  public void onCatalystInstanceDestroy() {
              ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/expo/workingdir/build/node_modules/@react-native-async-storage/async-storage/android/src/javaPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning
> Task :expo-modules-core:compileDebugKotlin
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':mattermost_react-native-emm:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
BUILD FAILED in 2m 36s
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
For more on this, please refer to https://docs.gradle.org/8.10.2/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
465 actionable tasks: 465 executed
Error: Gradle build failed with unknown error. See logs for the "Run gradlew" phase for more information.

anyone knows how to deal with it?

@enahum

[roeycohen]

hi @enahum,
surprisingly using v1.5.1 fixed the issue...
could it be that somehow the changes related applyBlurEffect throw errors on some situations?

[enahum]

Yes that was quickly done to cover some of our needs and I did not really double checked it was working on the new architecture as of today we still have not enabled it.

At some point when I have the chance (other priorities right now) will look into it and fix unless you are kind enough to submit a PR ;)

Thanks for reporting this

[roeycohen]

I would like to be kind enough for a PR @enahum :) problem is that I don't really know Kotlin...

[roeycohen]

hi @enahum, looking on the error message again, it seems like the issue is related to "An overriding function is not allowed to specify default values for its parameters".

and indeed, you defined a default radius of 10 here:

react-native-emm/android/src/newarch/java/com/EmmModule.kt

Line 104 in c041f96

override fun applyBlurEffect(radius: Float = 10f) {

here's a thread talking about this issue:
https://stackoverflow.com/a/37701185/314905

what do you think? can you maybe double check?

i would check myself, but i practically knows nothing about native app programming... and this is as close as i can get in terms of a PR...

[fridezlucas]

Thank you @roeycohen, I need this fix too! Hope this will be available soon 😄

[roeycohen]

you're welcome @fridezlucas :)

hi @enahum, can you accept the PR or give me your notes?