Repository navigation
Add a test for an event with an invalid signature - #821
Merged
Merged
Conversation
Member
Author
|
These fail, as expected, until matrix-org/synapse#6996 is merged into develop. |
richvdh
reviewed
Feb 27, 2020
richvdh
left a comment
richvdh
left a comment
Member
There was a problem hiding this comment.
generally looks good, just a few nits
Member
Author
|
Next run of these should succeed since the fix is now merged to develop. 👍 |
clokep
force-pushed
the
clokep/repro-send-join-error
branch
from
March 2, 2020 16:53
1063c24 to
c136fe7
Compare
Member
Author
|
This is now hitting #819. |
Member
Author
|
This is ready for review, but includes the changes from #823 to fix the build. I can rebase them out if that gets merged first. |
clokep
force-pushed
the
clokep/repro-send-join-error
branch
2 times, most recently
from
March 3, 2020 15:04
ed7c8e5 to
7d45396
Compare
clokep
changed the title
richvdh
approved these changes
Mar 4, 2020
richvdh
left a comment
richvdh
left a comment
Member
There was a problem hiding this comment.
lgtm other than the nits below!
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
clokep
force-pushed
the
clokep/repro-send-join-error
branch
from
March 4, 2020 15:41
2b3c87c to
2ed42bc
Compare
anoadragon453
added a commit
that referenced
this pull request
Mar 24, 2020
…ease-v1.12.x * origin/release-v1.12.0: Missing bits Use r0 instead of 'unstable' for joined_members|rooms Add test to optionally keep other sessions when modifying a user's password. (#832) Remove tests that call query_auth endpoint. (#827) Add tests for validating alt_aliases of a canonical alias event. (#824) Update the haproxy config to route fallback auth and register to the same worker. (#828) Add tests for a user with sufficient power level removing an alias. (#818) Add a test for an event with an invalid signature (#821) Fix race in self signing key tests. (#822) Use retry_until_success instead of repeat_until_true. Attempt to deflake a test. Fix frontend proxy worker binding to wrong port. (#823) Stop checking for aliases in the public room list. Attempt to deflake a sytest (#816) Fix formatting from review. Support running Dendrite in more than 1 sqlite db file Add tests for moving alt_aliases to an upgraded room. Support running dendrite in sqlite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reproduces the issue in matrix-org/synapse#6978.
Note that I created this test by copying, so it is a bit duplicative. I'm unsure how much of it is worth keeping.
On current develop (sans matrix-org/synapse#6996) this fails on the
log_if_fail "send_join event", $event;line.