Repository navigation
Update Synapse Admin API quarantine path - #1380
Merged
Merged
Conversation
This path was deprecated nearly 4 years ago in matrix-org/synapse#6681. The old path is consistently causing CI failures on `develop`.
erikjohnston
approved these changes
May 14, 2024
Member
Author
|
That test failure exists on |
Member
Author
|
The problem is that the Admin API request is going to the main process, whereas it should be going to the media worker. As we disable media functionality, including media-related Admin API functionality, in Sytest's Synapse when workers are enabled: sytest/lib/SyTest/Homeserver/Synapse.pm Line 265 in 7d3f92d |
Member
Author
Should be fixed by #1381. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This path was deprecated nearly 4 years ago in matrix-org/synapse#6681.