Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Unpin attrs dep after new version has been released #9946

Merged
erikjohnston merged 2 commits into from
May 7, 2021
Merged

Unpin attrs dep after new version has been released #9946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1caffad
Unpin attrs dep after new version has been released
erikjohnston May 7, 2021
fa6e165
Newsfile
erikjohnston May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/9946.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Unpin attrs dependency.
2 changes: 1 addition & 1 deletion synapse/python_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
# Fedora 31 only has 19.1, so if we want to upgrade we should wait until 33
# is out in November.)
# Note: 21.1.0 broke `/sync`, see #9936
"attrs>=19.1.0,<21.1.0",
"attrs>=19.1.0,!=21.1.0",

@callahad callahad May 7, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unnecessary; 21.1.0 was yanked from PyPI, so it effectively no longer exists. We can go back to just attrs>=19.1.0

@erikjohnston erikjohnston May 7, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, true. Though I think since we know its bad we may as well leave it in there. I'm not sure if e.g. pypi mirrors and the like handle yanking etc.

"netaddr>=0.7.18",
"Jinja2>=2.9",
"bleach>=1.4.3",
Expand Down