This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
Convert the message handler to async/await - #7884
Merged
Merged
Conversation
anoadragon453
suggested changes
Jul 20, 2020
anoadragon453
left a comment
anoadragon453
left a comment
Member
There was a problem hiding this comment.
A couple of small things here and there, but great overall.
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Member
Author
|
@anoadragon453 Thanks for the review! I handled all your comments or responded, let me know if I should make more changes! |
19 of 48 tasks
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'cc9bb3dc3': Convert the message handler to async/await. (#7884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last big piece of
synapse.handlersto convert. It was a bit more involved since it is touch in so many places. I converted this method by method as separate commits since I had previously tried to convert this and failed.The two interesting commits are 48c7f92 and e76d407. The rest are pretty mechanical.