This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
Support any process writing to cache invalidation stream. - #7436
Merged
Merged
Conversation
erikjohnston
changed the title
erikjohnston
force-pushed
the
erikj/split_cache_stream
branch
2 times, most recently
from
May 6, 2020 11:55
af43047 to
9eef604
Compare
This is now superfluous due to being able to write to the cache invalidation stream from any process.
erikjohnston
force-pushed
the
erikj/split_cache_stream
branch
from
May 6, 2020 12:24
9eef604 to
5779503
Compare
Member
|
@erikjohnston Looks like this has a conflict! |
Member
Author
But it didn't just now 😭 |
clokep
reviewed
May 6, 2020
clokep
reviewed
May 6, 2020
|
|
||
| DROP TABLE IF EXISTS cache_invalidation_stream; | ||
|
|
||
| CREATE TABLE cache_invalidation_stream ( |
Member
There was a problem hiding this comment.
I don't know if we care, but re-using this table name means it will be hard to downgrade.
Member
Author
There was a problem hiding this comment.
Good point, I've renamed it and truncated the old table.
clokep
approved these changes
May 6, 2020
clokep
left a comment
clokep
left a comment
Member
There was a problem hiding this comment.
I think this looks OK, modulo the couple of comments I left.
erikjohnston
force-pushed
the
erikj/split_cache_stream
branch
from
May 7, 2020 10:55
493ef66 to
f3e5d26
Compare
phil-flex
pushed a commit
to phil-flex/synapse
that referenced
this pull request
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done via two big changes:
MultiWriterIdGeneratorStream.current_tokento accept an instance name parameter, which allows us to support the idea of there being multiple writers and so multiple positions to keep track of.Its probably worth going through commit by commit, as there is a bit of boiler plate refactoring going on.