Background await fix

[selrahal]

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file
• Pull request includes a sign off
• Code style is correct (run the linters)

[selrahal]

I'm not tied to this changeset, but it worked as a stop-gap for me to perform my sqlite3 to postgres migration. Don't know much async python, feel free to just decline if this isn't helpful.

This is already being tracked in @babolivier issue: #6719

[babolivier]

Hey @selrahal, and thanks for your contribution!

Unfortunately, this fix can't really work as do_next_background_update and has_completed_background_updates are asynchronous functions that should be awaited (either with a await if the code calling these functions has been converted to async/awayt, or with a yield otherwise). As you can see in the CI, your change doesn't really fix the issue.

On top of that, I've already opened a PR to fix that: #6718 ; the right solution is to port the script to async/await and as you can see it's not as trivial as it might seem (and that PR also fixes a bug on the error handling that explains why the CI on your PR is passing despite the script failing).

Because of these two reasons, I'm going to close this PR. Thanks for your contribution and effort nonetheless, and hopefully that won't prevent you from contributing further! 🙂