Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Port some admin handlers to async/await - #6559

Merged
erikjohnston merged 3 commits into
developfrom
erikj/async_await
Dec 19, 2019
Merged

erikjohnston merged 3 commits into
developfrom
erikj/async_await

Conversation

@erikjohnston

Copy link
Copy Markdown
Member

No description provided.

@erikjohnston
erikjohnston requested a review from a team December 17, 2019 13:13
Comment thread synapse/handlers/admin.py

@defer.inlineCallbacks
def export_user_data(self, user_id, writer):
async def export_user_data(self, user_id, writer):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks like it's got a yield in admin_cmd.py

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point. Apparently even searching for function references correctly was too much for me on Tuesday

@erikjohnston
erikjohnston requested a review from a team December 19, 2019 11:04
@erikjohnston
erikjohnston merged commit 3d46124 into develop Dec 19, 2019
@erikjohnston
erikjohnston deleted the erikj/async_await branch January 9, 2020 15:47
@clokep clokep mentioned this pull request Jul 30, 2020
19 of 48 tasks
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '3d46124ad':
  Port some admin handlers to async/await (#6559)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants