Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Trace non-JSON APIs, /media, /key etc - #6195

Merged
erikjohnston merged 2 commits into
developfrom
erikj/opentracing_preview_url
Oct 11, 2019
Merged

erikjohnston merged 2 commits into
developfrom
erikj/opentracing_preview_url

Conversation

@erikjohnston

Copy link
Copy Markdown
Member

This should reduce the number of There was no active span when trying to set a tag. Did you forget to start one or did a context slip? errors

@erikjohnston
erikjohnston requested a review from a team October 11, 2019 10:24
@erikjohnston
erikjohnston force-pushed the erikj/opentracing_preview_url branch from 108386c to 4d4ac5d Compare October 11, 2019 10:56

@richvdh richvdh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston
erikjohnston merged commit 6f5c6c8 into develop Oct 11, 2019
@erikjohnston
erikjohnston deleted the erikj/opentracing_preview_url branch January 9, 2020 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants