Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Clean up the database pagination code - #5007

Merged
hawkowl merged 3 commits into
developfrom
hawkowl/paginate-cleanup
Apr 4, 2019
Merged

hawkowl merged 3 commits into
developfrom
hawkowl/paginate-cleanup

Conversation

@hawkowl

@hawkowl hawkowl commented Apr 4, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@hawkowl
hawkowl requested a review from a team April 4, 2019 11:44
@codecov

codecov Bot commented Apr 4, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5007 into develop will increase coverage by <.01%.
The diff coverage is 15.38%.

@@             Coverage Diff             @@
##           develop    #5007      +/-   ##
===========================================
+ Coverage     60.7%   60.71%   +<.01%     
===========================================
  Files          332      332              
  Lines        34172    34170       -2     
  Branches      5633     5634       +1     
===========================================
  Hits         20745    20745              
+ Misses       11956    11954       -2     
  Partials      1471     1471

@richvdh richvdh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems plausible. Suspect this is untested so who knows tbqh

@hawkowl
hawkowl merged commit a33a5ab into develop Apr 4, 2019
@hawkowl
hawkowl deleted the hawkowl/paginate-cleanup branch April 4, 2019 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants