This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
A set of improvements to the Limiter - #3571
Merged
Merged
Conversation
richvdh
commented
Jul 20, 2018
richvdh
commented
Member
- Add a sleep to fix stack overflows (fixes maximum recursion depth exceeded under heavy use of a Limiter #3570)
- Give them names, to improve logging
- Merge with Linearizer, to reduce code duplication
* give them names, to improve logging * use a deque rather than a list for efficiency
Linearizer was effectively a Limiter with max_count=1, so rather than maintaining two sets of code, let's combine them.
Member
Author
|
(hopefully the individual commits are easier to review than the whole thing here) |
Member
Author
|
(because this renames Limiter to Linearizer, we'll need to be careful when merging to matrix-org-hotfixes, which has an extra Limiter instance) |
erikjohnston
approved these changes
Jul 20, 2018
This was referenced Jul 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.