This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
Reintroduce membership tables event stream ordering - #15128
Merged
DMRobertson merged 13 commits intoMar 24, 2023
Merged
DMRobertson merged 13 commits into
DMRobertson merged 13 commits into
Conversation
Specifically this adds the column to `current_state_events`, `local_current_membership` and `room_memberships`. Each of these tables is regularly joined with the `events` table to get the stream ordering and denormalising this into each table will yield significant query performance improvements once used.
Fizzadar
changed the title
Fizzadar
marked this pull request as ready for review
February 22, 2023 08:23
DMRobertson
suggested changes
Feb 27, 2023
DMRobertson
left a comment
DMRobertson
left a comment
Contributor
There was a problem hiding this comment.
I think we should be bumping SCHEMA_VERSION to 74 here
(with a comment explaining what's changed in version 74), but leave SCHEMA_COMPAT_VERSION at 73.
DMRobertson
added
the
X-Awaiting-Changes
Contributor
Author
|
Argh can't believe I missed this! @DMRobertson I think this should be bumping the compat version now? Once this is applied the schema cannot be rolled back before 74. 6901682 |
Contributor
|
Err, I think I got SCHEMA_VERSION and SCHEMA_COMPAT_VERSION mixed up. I also completely forgot about #15036. (It seems the local branch I used to generate that link is a little out of date 🤦)
Agreed: as of this change, Synapse needs to make disambiguated queries. |
DMRobertson
reviewed
Feb 27, 2023
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
DMRobertson
previously approved these changes
Feb 27, 2023
DMRobertson
left a comment
DMRobertson
left a comment
Contributor
There was a problem hiding this comment.
Looks sane to me, but it might be worth a second pair of eyes since we messed up last time.
richvdh
reviewed
Feb 27, 2023
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
…bership tables" This reverts commit da71761.
Contributor
Author
|
Concerns addressed and background update part removed! |
richvdh
reviewed
Mar 22, 2023
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
erikjohnston
added a commit
that referenced
this pull request
Mar 29, 2023
This reverts commit e6af49f.
erikjohnston
added a commit
that referenced
this pull request
Mar 29, 2023
Fizzadar
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Mar 30, 2023
…atrix-org#15128)" (matrix-org#15347)" This reverts commit 5350b5d.
Fizzadar
added a commit
to Fizzadar/synapse
that referenced
this pull request
Apr 20, 2023
…atrix-org#15128)" (matrix-org#15347)" This reverts commit 5350b5d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reintroduces #14979 with fixes per #15014.
Original description:
This adds an
event_stream_orderingcolumn tocurrent_state_events,local_current_membershipandroom_memberships. Each of these tables is regularly joined with theeventstable to get the stream ordering and denormalising this into each table will yield significant query performance improvements once used.Includes a background job to populate these values from thepushed back for now.eventstableSame idea as #13703 which has been a significant improvement on our database instance, suspect once applied this will be far greater.
Signed off by Nick @ Beeper (@Fizzadar).
Pull Request Checklist
(run the linters)
Closes: #15014