This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
Fix track_memory_usage on poetry-core 1.3.x installations - #14221
Merged
Merged
Conversation
added 2 commits
October 18, 2022 12:57
The same kind of problem as discussed in #14085: 1. we defined an extra with an underscore 2. we look it up at runtime with an underscore 3. but poetry-core 1.3.x. installs it with a dash, causing (2) to fail. Fix by using a dash everywhere.
Contributor
Author
|
I guess we didn't see this in CI because we install |
clokep
approved these changes
Oct 18, 2022
Member
|
(I'm assuming you've double checked there are no other extras with this issue!) |
Contributor
Author
I did this time, yeah. 😓 |
Contributor
Author
|
Complement flake is #14183. |
Fizzadar
pushed a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Oct 19, 2022
…rg#14221) * Fix `track_memory_usage` on poetry-core 1.3.x installations The same kind of problem as discussed in matrix-org#14085: 1. we defined an extra with an underscore 2. we look it up at runtime with an underscore 3. but poetry-core 1.3.x. installs it with a dash, causing (2) to fail. Fix by using a dash everywhere. * Changelog # Conflicts: # pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same kind of problem as discussed in #14085:
Fix by using a dash everywhere.