This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
Fix notification count after a highlighted message - #13223
Merged
Merged
Conversation
erikjohnston
marked this pull request as ready for review
July 8, 2022 11:12
DMRobertson
reviewed
Jul 8, 2022
DMRobertson
approved these changes
Jul 8, 2022
DMRobertson
left a comment
DMRobertson
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for explaining.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crux of the problem was that when we rotated the notifications we didn't filter out read-but-highlighted messages. This only affected highlights as we delete non-highlights after they're read.
Fixes #13196
Broke by #13005