This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
Fix bug where we failed to delete old push actions - #13194
Merged
Merged
Conversation
This happened if we encountered a stream ordering in `event_push_actions` that had more rows than the batch size of the delete.
erikjohnston
marked this pull request as ready for review
July 6, 2022 10:11
erikjohnston
added
the
X-Regression
reivilibre
approved these changes
Jul 6, 2022
reivilibre
left a comment
reivilibre
left a comment
Contributor
There was a problem hiding this comment.
LGTM with explanation
Co-authored-by: reivilibre <oliverw@matrix.org>
erikjohnston
enabled auto-merge (squash)
July 6, 2022 10:29
erikjohnston
disabled auto-merge
July 6, 2022 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happened if we encountered a stream ordering in
event_push_actionsthat had more rows than the batch size of the delete, as If we don't delete any rows in an iteration then the next time round we get the exact same stream ordering and get stuck.Broke in #13005