This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
Track and deduplicate in-flight requests to _get_state_for_groups. - #10870
Merged
Merged
Conversation
reivilibre
requested review from
erikjohnston
and removed request for
erikjohnston
September 21, 2021 16:00
More to follow when #10825 is ready.
reivilibre
force-pushed
the
rei/gsfg_1
branch
from
September 21, 2021 16:14
e7fe187 to
a30042b
Compare
reivilibre
marked this pull request as ready for review
September 21, 2021 16:17
Contributor
Author
|
I'm going to add some more tests when #10825 is available so I can actually prove that things get deduplicated, but would like some thoughts on if this seems sensible. |
This reverts commit 363565e because a proper implementation is now in develop.
to introduce `approx_difference`.
erikjohnston
previously requested changes
Oct 12, 2021
erikjohnston
added
the
X-Awaiting-Changes
clokep
reviewed
Feb 11, 2022
clokep
reviewed
Feb 11, 2022
clokep
reviewed
Feb 11, 2022
|
|
||
| d.callback(result) | ||
|
|
||
| def test_duplicate_requests_deduplicated(self) -> None: |
Member
There was a problem hiding this comment.
This test seems nuanced enough that it could use a docstring saying what the overall steps are that are happening.
Contributor
Author
There was a problem hiding this comment.
Added one; any good?
clokep
reviewed
Feb 11, 2022
clokep
reviewed
Feb 11, 2022
clokep
reviewed
Feb 11, 2022
clokep
reviewed
Feb 11, 2022
clokep
reviewed
Feb 11, 2022
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
clokep
approved these changes
Feb 16, 2022
clokep
left a comment
clokep
left a comment
Member
There was a problem hiding this comment.
Seems reasonable, thank you for the explanations!
clokep
approved these changes
Feb 17, 2022
clokep
left a comment
clokep
left a comment
Member
There was a problem hiding this comment.
Changes seem good! 👍 This has a failing sytest which I don't think I've seen before though.
This was referenced Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the 2nd PR of a series (expected to have 4 PRs) to address #10301 .
Depends on #10825.
The general idea is that when requesting some state, we make use of existing queries that are already in-flight.
Those queries might only give us partial information, so we may have to use multiple, and we may even have to spawn our own (smaller) query for the leftover state.
Coming up later: