This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Implement a blacklisting endpoint (instead of a blacklisting reactor and agent wrapper) #8860
Description
See #8821 (comment) for background on this.
Currently to apply an IP range blacklist in Synapse it is necessary to wrap the the reactor with BlacklistingReactorWrapper and then the agent with BlacklistingAgentWrapper. Ideally all of this logic could be encompassed in a custom BlacklistingHostnameEndpoint which would implement similar logic to HostnameEndpoint, but apply the blacklisting logic to it (the necessary logic is almost identical to what is currently in _IPBlacklistingResolver).
This should allow creating an agent with Agent. usingEndpointFactory.
Some things to note:
- This has to fit in somehow with the
ProxyAgent(I suspect it should be an either or sort of thing, but not this should be further investigated). - The separation of
SimpleHttpClientandMatrixFederationClientmakes this a bit more difficult. - There's also some use of the
RedirectAgentwhich may or may not be involved here.
Activity
richvdh commentedon Jan 13, 2021
is this now resolved thanks to #9084?
clokep commentedon Jan 13, 2021
I think so, I think what you would end up doing is using a new
BlacklistingEndpointinstead of theHostnameEndpointwhen not using the proxy.clokep commentedon Jun 22, 2021
I had started playing with this briefly, but I don't remember if I even tested it... anyway my WIP was 854ed2a if that's useful to anyone. 😄