This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Docker image no longer starts if you set SYNAPSE_SMTP_HOST #5430
Description
As far as I can tell, the SYNAPSE_SMTP_* settings were never used, because email_notifs was set to false in the homeserver.yaml used by the docker image. Nevertheless the documentation kinda encourages you to set the SYNAPSE_SMTP_* settings. Those that did so will now find that their servers refuse to start, with:
RuntimeError: email.password_reset_behaviour is set to 'local' but no public_baseurl is set. This is necessary to generate password reset links
Activity
richvdh commentedon Jun 11, 2019
The workarounds for now are either:
SYNAPSE_SMTP_*env vars (will disable password reset on your server)SYNAPSE_CONFIG_PATHanoadragon453 commentedon Jun 21, 2019
A quick fix before figuring out the whole Docker mess is just to add a
SYNAPSE_PUBLIC_BASEURLenvironment variable. This behaviour has been implemented in #5519.But we should really figure this out :/
richvdh commentedon Jun 21, 2019
I'm not convinced adding a
SYNAPSE_PUBLIC_BASEURLis the best approach.We're going to be telling people to switch to the
SYNAPSE_CONFIG_PATHapproach, so rather than having them add aSYNAPSE_PUBLIC_BASEURL, I think we should tell them to switch to a generated file.The only question is whether we can do something better for people whose working configs have been broken by 1.0, like disabling password resets altogether?
Given the
SYNAPSE_SMTP_vars are unused in synapse <0.99, maybe we should just remove them, and skip generating theemailconfig section?richvdh commentedon Jun 21, 2019
(incidentally it might be good to do that against the release branch and we can update the docker image on dockerhub.)
anoadragon453 commentedon Jun 24, 2019
This sounds best to me, considering, as you say, they were never actually used.
hawkowl commentedon Jun 25, 2019
Because of #5518, I believe we can say "use a proper config" here, and close it?
richvdh commentedon Jun 25, 2019
As per #5430 (comment): I'd prefer not to break peoples' working configs, and I think we can do better.
xobs commentedon Jul 3, 2019
The
README.mdon https://hub.docker.com/r/matrixdotorg/synapse still documents those variables, so that should first be removed prior to closing this issue.Remove SMTP_* env var functionality from docker conf (#5596)
richvdh commentedon Jul 3, 2019
the readme will be updated at the same time as the docker image is updated on hub.docker.
fixed by #5596