Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Failure to download image for URL preview should not fail the whole preview #5298

Closed

Description

@turt2live

Currently Synapse uses OpenGraph to try and find an image. If that fails, it'll pick an image from the DOM. If the image from either fails to download (403, 404, too large, etc) then Synapse should just return a preview without an image. Currently, it instead throws a 502 error instead.

Activity

  1. akontsevich commented on May 30, 2019

    @akontsevich

    изображение
    This is preview from Skype, for example. However it is not the only problem: as I mentioned nothing from youtube works, many other sites like this: https://hdrezka-me.me/22654-teni-ischezayut-v-polden-95051943.html, livejournal, etc - nothing works actually.

  2. akontsevich commented on Jun 2, 2019

    @akontsevich

    Inserting new youtube link shows preview, however all previous links or on next days links are not previewed. So could be both synapse and client bugs.

  3. akontsevich commented on Jun 19, 2019

    @akontsevich

    Happen again today for some links, yesterday preview was normal for that link, for example:
    https://rezka.ag/series/drama/13646-blokada.html

  4. Kevin-Mok commented on Sep 3, 2019

    @Kevin-Mok

    I have a site hosting Twitch emotes that I used to reference to preview the emote. It was just working the last couple of days but suddenly stopped working. Previews from other images not on that site still work fine, so I'm not sure what happened.

    It used to just work like this but now doesn't show anything, even though the link is still valid:
    7d37a7c0876078d3

    Edit: They started working again after a few hours.

  5. akontsevich commented on Oct 2, 2019

    @akontsevich

    Issue appeared again. Please fix!

  6. akontsevich commented on Oct 19, 2019

    @akontsevich
  7. added
    T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.
    on Apr 25, 2022
  8. self-assigned this
    on Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.z-bug(Deprecated Label)z-p2(Deprecated Label)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions