Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

URL preview IP blacklist doesn't work on IPv6 and isn't bulletproof #4242

Closed

Description

@hawkowl

We need to have another look at this, especially after #4215 , which changes where the IP blacklist check is done, and is potentially vulnerable to an attack where a super low TTL or no DNS caching can have the check pass on a non whitelisted IP and then the request be made to a refetched DNS query which has a blacklisted IP.

Activity

  1. hawkowl commented on Dec 21, 2018

    @hawkowl
    ContributorAuthor

    #4215 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions