Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Enable Synapse to connect to redis logical DB #15009

Closed

Description

@999lakhisidhu

Currently for Redis Database for distributed deployment (with workers). The available config option are redis host, port, there is no option in configuration to specify logical redis DB. The dependency synapse is using "txredisapi" does support the connection to a logical redis DB. Is it possible to enable the same in Synapse configuration?

Activity

  1. added
    S-MinorBlocks non-critical functionality, workarounds exist.
    T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.
    O-UncommonMost users are unlikely to come across this or unexpected workflow
    on Feb 7, 2023
  2. clokep commented on Feb 7, 2023

    @clokep
    Member

    That sounds reasonable -- we would certainly accept a patch adding support for this. It should just be threading through the new configuration with a default to whatever happens if you don't provide it.

  3. waclaw66 commented on Feb 11, 2023

    @waclaw66

    @999lakhisidhu: https://redis.io/docs/manual/pubsub/
    Pub/Sub has no relation to the key space. It was made to not interfere with it on any level, including database numbers.

  4. 999lakhisidhu commented on Feb 11, 2023

    @999lakhisidhu
    ContributorAuthor

    @waclaw66 I agree for pub/sub it may not matter, if you are connecting with a logical keyspace or normal connection but here we are storing some key,value pairs as well(i have observed it in redis db connected to synapse)… so these key, values can be segregated as per logical db..

  5. waclaw66 commented on Feb 11, 2023

    @waclaw66

    i have observed it in redis db connected to synapse)… so these key, values can be segregated as per logical db..

    I haven't seen any key-value in redis. What kind of data are stored there?

  6. 999lakhisidhu commented on Feb 11, 2023

    @999lakhisidhu
    ContributorAuthor

    `[test@cloud]$ redis-cli -h localhost -p 6379 -n 3
    localhost:6379[3]> keys *

    1. "cache_v1:event_to_prev_state_group:$1tpX6kQNwghBprqdpVCCU7PMK9brZPbeCZfV2TFM664"
    2. "cache_v1:event_to_prev_state_group:$Cr35pecVCiC43-IjNqFtWIFUblXU0-cTAwnOUAc6JD4"
    3. "cache_v1:get_joined_hosts:23"
    4. "cache_v1:event_to_prev_state_group:$KaqNr2RybuLz9uxmAMBSsI2gTVP1cMD1WLs78ShIFIs"
    5. "cache_v1:event_to_prev_state_group:$bmw-x_N4HJQlrBvOs8ct_hpzxFL-Ue6hO535DjnYhmA"
      localhost:6379[3]> GET "cache_v1:event_to_prev_state_group:$Cr35pecVCiC43-IjNqFtWIFUblXU0-cTAwnOUAc6JD4"
      "23"
      localhost:6379[3]>
      `
      @waclaw66 this is the snapshot for key,value pairs stored in redis DB
  7. linked a pull request that will close this issueAdding support for redis logical db #15034on Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    O-UncommonMost users are unlikely to come across this or unexpected workflowS-MinorBlocks non-critical functionality, workarounds exist.T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions